Skip to content

Conversation

@YegorKozlov
Copy link
Contributor

Patch for #917

@google-cla
Copy link

google-cla bot commented Jul 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 8, 2021
@YegorKozlov
Copy link
Contributor Author

YegorKozlov commented Jul 8, 2021 via email

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 8, 2021
@barbeau barbeau changed the title Poor performance of StaticCluster#remove #917 perf: Use LinkedHashMap instead of List in StaticCluster Jul 8, 2021
@barbeau barbeau changed the title perf: Use LinkedHashMap instead of List in StaticCluster perf: Use LinkedHashSet instead of List in StaticCluster Jul 8, 2021
Copy link
Collaborator

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YegorKozlov for pointing this out! And yes, I believe it does need to be a LinkedHashSet, because we already had an issue with the cluster contents shifting on re-cluster if insert order isn't maintained in other data structures (see #624).

@barbeau barbeau merged commit 1b6e817 into googlemaps:main Jul 8, 2021
@barbeau barbeau assigned barbeau and unassigned arriolac Jul 8, 2021
googlemaps-bot pushed a commit that referenced this pull request Jul 8, 2021
## [2.2.5](v2.2.4...v2.2.5) (2021-07-08)

### Performance Improvements

* Use LinkedHashSet instead of List in StaticCluster ([#918](#918)) ([1b6e817](1b6e817)), closes [#917](#917)
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants