Skip to content

Conversation

@illuminati1911
Copy link
Contributor

@illuminati1911 illuminati1911 commented Feb 26, 2025

Implements #284

Introduces a new property taskRemovedBehavior to createNavigationSession function that can be used to tell Android sdk to close navigation on application exit or to keep it running.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation
  • I added new tests to check the change I am making
  • All existing and new tests are passing.

Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
with small nit

@jokerttu
Copy link
Contributor

@illuminati1911 Please update readme to include instructions on this

@illuminati1911 illuminati1911 marked this pull request as ready for review February 27, 2025 09:05
@jokerttu jokerttu force-pushed the feat/support-navigation-disposal-on-app-exit branch from 044e91f to 87016ea Compare February 27, 2025 11:17
@jokerttu jokerttu merged commit 8bc03c1 into main Feb 27, 2025
11 checks passed
@jokerttu jokerttu deleted the feat/support-navigation-disposal-on-app-exit branch February 27, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants