Skip to content

Conversation

@BiniCodes
Copy link
Contributor

  • adds mock for advanced marker view

  • adds test for advanced marker view mock

  • adds mock for pin view

  • adds test for pin view mock

Closes #397 and closes #396 📍

@amuramoto
Copy link
Member

@BiniCodes can you please take a look at the test failures for this PR? Thank you!

@BiniCodes
Copy link
Contributor Author

@BiniCodes can you please take a look at the test failures for this PR? Thank you!

Similar here, I would need the type update from this PR #403 to get the google.maps.marker.AdvancedMarkerView 🤔

@BiniCodes BiniCodes requested a review from amuramoto March 16, 2023 13:10
@amuramoto amuramoto changed the title Feat/add advanced marker view feat: add advanced marker view Mar 17, 2023
@amuramoto amuramoto merged commit db5c67f into googlemaps:main Mar 17, 2023
github-actions bot pushed a commit that referenced this pull request Mar 17, 2023
* feat: add mocks for advanced marker view

* feat: add mocks for pin view db5c67f
googlemaps-bot pushed a commit that referenced this pull request Mar 17, 2023
## [2.17.0](v2.16.2...v2.17.0) (2023-03-17)

### Features

* add advanced marker view ([#407](#407)) ([db5c67f](db5c67f))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 2.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PinView: Add mock for google.maps.marker.PinView Advanced Markers: Add mock for google.maps.marker.AdvancedMarkerView

4 participants