Skip to content

fix: skip clustering for when list of markers is empty #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025
Merged

fix: skip clustering for when list of markers is empty #1014

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fa8a0a
fix: skip clustering for when list of markers is empty
usefulthink Jul 8, 2025
23226e9
Merge branch 'main' into fix/empty-markers-list
usefulthink Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/algorithms/supercluster.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,10 @@ export class SuperClusterAlgorithm extends AbstractAlgorithm {
const position = MarkerUtils.getPosition(marker);
const coordinates = [position.lng(), position.lat()];
return {
type: "Feature" as const,
geometry: {
type: "Point" as const,
coordinates,
},
type: "Feature",
geometry: { type: "Point", coordinates },
properties: { marker },
};
} as const;
});
this.superCluster.load(points);
}
Expand All @@ -87,6 +84,13 @@ export class SuperClusterAlgorithm extends AbstractAlgorithm {

this.state = state;

// when input is empty, return right away
if (input.markers.length === 0) {
this.clusters = [];

return { clusters: this.clusters, changed };
}

if (changed) {
this.clusters = this.cluster(input);
}
Expand Down
Loading