Skip to content

refactor(utils): add type guard to isAdvancedMarker #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023
Merged

refactor(utils): add type guard to isAdvancedMarker #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions src/marker-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,28 +20,26 @@
*/

export class MarkerUtils {
public static isAdvancedMarker(marker: Marker): boolean {
if (
public static isAdvancedMarker(
marker: Marker
): marker is google.maps.marker.AdvancedMarkerElement {
return (
google.maps.marker &&
marker instanceof google.maps.marker.AdvancedMarkerElement
) {
return true;
}
return false;
);
}

public static setMap(marker: Marker, map: google.maps.Map | null) {
if (this.isAdvancedMarker(marker)) {
(marker as google.maps.marker.AdvancedMarkerElement).map = map;
return;
marker.map = map;
} else {
(marker as google.maps.Marker).setMap(map);
}
(marker as google.maps.Marker).setMap(map);
}

public static getPosition(marker: Marker): google.maps.LatLng {
// SuperClusterAlgorithm.calculate expects a LatLng instance so we fake it for Adv Markers
if (this.isAdvancedMarker(marker)) {
marker = marker as google.maps.marker.AdvancedMarkerElement;
if (marker.position) {
if (marker.position instanceof google.maps.LatLng) {
return marker.position;
Expand Down