Skip to content

refactor: misc minor cleanup #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2023
Merged

refactor: misc minor cleanup #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 0 additions & 51 deletions .github/workflows/e2e.yml
View file
Open in desktop

This file was deleted.

Empty file removed e2e/README.md
View file
Open in desktop
Empty file.
4 changes: 0 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
"lint": "eslint .",
"prepare": "rm -rf dist && rollup -c",
"test": "jest --passWithNoTests src/*",
"test:e2e": "jest --passWithNoTests e2e/*",
"test:all": "jest"
},
"dependencies": {
Expand All @@ -54,18 +53,15 @@
"@types/d3-interpolate": "^3.0.1",
"@types/google.maps": "^3.53.1",
"@types/jest": "^27.0.1",
"@types/selenium-webdriver": "^4.0.9",
"@types/supercluster": "^7.1.0",
"@typescript-eslint/eslint-plugin": ">=4.1.0",
"@typescript-eslint/parser": ">=4.1.0",
"chromedriver": "^113.0.0",
"core-js": "^3.6.5",
"d3-interpolate": "^3.0.1",
"eslint": "^8.41.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-jest": "^27.0.1",
"eslint-plugin-prettier": "^4.0.0",
"geckodriver": "^4.0.0",
"jest": "^26.4.2",
"prettier": "^2.1.1",
"rollup": "^2.26.11",
Expand Down
6 changes: 3 additions & 3 deletions src/marker-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export class MarkerUtils {
if (this.isAdvancedMarker(marker)) {
marker.map = map;
} else {
(marker as google.maps.Marker).setMap(map);
marker.setMap(map);
}
}

Expand All @@ -58,7 +58,7 @@ export class MarkerUtils {
}
return new google.maps.LatLng(null);
}
return (marker as google.maps.Marker).getPosition();
return marker.getPosition();
}

public static getVisible(marker: Marker) {
Expand All @@ -72,6 +72,6 @@ export class MarkerUtils {
*/
return true;
}
return (marker as google.maps.Marker).getVisible();
return marker.getVisible();
}
}