Skip to content

fix: address a couple of issues on the Android side #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2024
Merged

fix: address a couple of issues on the Android side #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d380468
fix: request ACCESS_FINE_LOCATION as required by Android NavSDK
ArturoSalazarB16 Feb 14, 2024
859a2a5
fix: add optional logDebugInfo callback
ArturoSalazarB16 Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SampleApp/src/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ const App: React.FC = (): ReactElement => {
const checkPermissions = async () => {
const result = await request(
Platform.OS == 'android'
? PERMISSIONS.ANDROID.ACCESS_COARSE_LOCATION
? PERMISSIONS.ANDROID.ACCESS_FINE_LOCATION
: PERMISSIONS.IOS.LOCATION_ALWAYS,
);

Expand Down
9 changes: 9 additions & 0 deletions components/navigation/navigationView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,14 @@ export default class NavigationView extends React.Component<NavigationViewProps>
}
};

logDebugInfo = (message: string) => {
if (
this.props.navigationViewCallbacks != null &&
this.props.navigationViewCallbacks.logDebugInfo != null) {
this.props.navigationViewCallbacks.logDebugInfo(message);
}
};

/**
* Callback invoked when tapping on marker's info window.
* @platform Android only
Expand Down Expand Up @@ -345,6 +353,7 @@ export default class NavigationView extends React.Component<NavigationViewProps>
NavModuleEvt.addListener('onPolylineClick', this.onPolylineClick);
NavModuleEvt.addListener('onPolygonClick', this.onPolygonClick);
NavModuleEvt.addListener('onCircleClick', this.onCircleClick);
NavModuleEvt.addListener('logDebugInfo', this.logDebugInfo);
};

/**
Expand Down
7 changes: 7 additions & 0 deletions components/navigation/navigationView/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,13 @@ export interface NavigationViewCallbacks {
* @param errorCode - indicates the reason why navigation failed to initialize.
*/
onNavigationInitError?(errorCode: NavigationInitErrorCode): void;

/**
* Allows developers to listen for relevant debug logs.
*
* @param message relevant log message
*/
logDebugInfo?(message: string): void;
}

/**
Expand Down