Skip to content
This repository was archived by the owner on Oct 19, 2023. It is now read-only.

Conversation

@workingmonk
Copy link
Contributor

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@workingmonk
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@Fleker
Copy link
Contributor

Fleker commented Feb 13, 2018

Thanks. Is that the only place we use flush in the project?

@Fleker Fleker requested review from Fleker and proppy February 13, 2018 02:17
@workingmonk
Copy link
Contributor Author

I went through the whole setup process on the Raspbian Strech today and on Python 2.7, this is the only blocker. Fixing this, I was able to get the Assistant up and running in no time.

@workingmonk
Copy link
Contributor Author

Quick repo search tells me that this is the only place with flush in the print statement

@Fleker
Copy link
Contributor

Fleker commented Feb 13, 2018

Based on the SO question, it looks like one solution is to use from __future__ import print_function, which is at the top of the file. I am curious as to why that does not work.

@workingmonk
Copy link
Contributor Author

workingmonk commented Feb 20, 2018

@Fleker I tried it with and without the import statement.

Without the import statement, it is a Compilation error
https://ideone.com/FtNFzO

With the import statement, it is a RunTime error for flush being an invalid argument
https://ideone.com/a00yNv

@workingmonk
Copy link
Contributor Author

so, now that the PR is approved, can you tell me about this Repo's merging and deploy schedules? would love for this issue to be fixed next time I pull the changes down :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants