Slightly improve performance of class lookup in VersionHandler

Stewart Miles · Stewart Miles · commit c731e945e72e · 2019-10-28T14:18:41.000-07:00
VersionHandler.FindClass() iterating through all classes in the app domain
after the class being searched for was found. This fixes the method to
stop searching when the class has been found.

Change-Id: I597a657d6cdddd486c419e3827a068adc808a5a7
diff --git a/source/VersionHandler/src/VersionHandler.cs b/source/VersionHandler/src/VersionHandler.cs
@@ -442,6 +442,7 @@ public static Type FindClass(string assemblyName, string className) {
                     foreach (var currentType in assembly.GetTypes()) {
                         if (currentType.FullName == className) {
                             type = currentType;
+                            break;
                         }
                     }
                     if (type != null) break;

Original file line number	Diff line number	Diff line change
`@@ -442,6 +442,7 @@ public static Type FindClass(string assemblyName, string className) {`
`442`	`442`	`foreach (var currentType in assembly.GetTypes()) {`
`443`	`443`	`if (currentType.FullName == className) {`
`444`	`444`	`type = currentType;`
	`445`	`+ break;`
`445`	`446`	`}`
`446`	`447`	`}`
`447`	`448`	`if (type != null) break;`