Check for token !== null #40
Conversation
If the Property Store returns a null token, this will throw an exception.
|
Under what circumstances would the token be null at this point? Is it just a case where the PropertiesService returns null incorrectly? |
|
I was checking the logs of my Twitter app that uses this library and there were quite a few errors that read - "Cannot read property public from null." The returned token was null and the method is trying to read a property from a null value. |
|
Gotcha. I think in that case throwing the "Token mistmatch" error would actually be incorrect, since that's not the root of the problem. What about calling the Are you setting a cache when you setup the service? That could help if the root cause is the |
|
Could you please remove me from this email? We are Active Controls, not Active Control
… On Jun 5, 2018, at 11:25 AM, Eric Koleda ***@***.***> wrote:
Gotcha. I think in that case throwing the "Token mistmatch" error would actually be incorrect, since that's not the root of the problem. What about calling the validate_ method on the token after you fetch it? It will still throw an error in this case, but a more explicit one.
Are you setting a cache <https://github.com/gsuitedevs/apps-script-oauth1/blob/master/src/Service.gs#L192> when you setup the service? That could help if the root cause is the PropertiesService is returning stale data.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#40 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALMuraeP5iyfVHhBM9zpYWCK8JstZyFGks5t5qL8gaJpZM4Uamxl>.
|
|
@AdminAC - To stop getting email you need to un-watch this repository. https://github.com/gsuitedevs/apps-script-oauth1/watchers |
|
Will merge this in, but concerned the underlying cause is still out there. Thanks for contributing! |
3 participants
If the Property Store returns a null token, this will throw an exception.