Updated to ES6 #240
Merged
Updated to ES6 #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update code with comments and ES6 features
sqrrrl
reviewed
Dec 6, 2021
Member
sqrrrl
left a comment
sqrrrl
left a comment
There was a problem hiding this comment.
A few minor changes, otherwise looks good.
Closed
Priyanka patch
Added try-catch used let and const
sqrrrl
reviewed
Dec 10, 2021
drive/quickstart/quickstart.gs
Outdated
| } | ||
| } | ||
| catch(err){ | ||
| Logger.log(err) |
Member
There was a problem hiding this comment.
Not critical, but here and elsewhere where catching exceptions for illustrative purposes to include a comment indicating two things:
- The developer should likely modify the code
- What is potentially failing
This is particularly important if the try block covers a large section of code as it's not always obvious where the failure might come from. Doesn't have to be a lengthy explanation, can be as short as "// TODO(developer) - Handle files.list() exceptions here"
sqrrrl
approved these changes
Dec 10, 2021
Update advanced gmail.gs file
Added try-catch in quickstart
brentchang
pushed a commit
to brentchang/apps-script-samples
that referenced
this pull request
Dec 3, 2023
Co-authored-by: Priyankarp24 <savat@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to ES6
Added try catch
Modified Region tag
Modified comments