Skip to content
This repository was archived by the owner on Sep 5, 2019. It is now read-only.

Conversation

SimonSimCity
Copy link
Contributor

This commit fixes the issue that you where unable to get a definition for a class that is internal.
The problem here is that you cannot get the default value for an internal class and therefore the system crashed with an exception.

Now added the following comment instead of the default value: */* internal default /
This comment, furthermore, is just added if the value NULL is not allowed. If NULL, I assume that it's also the default-value. I don't know how this is handled in native extensions, but in PHP user code (what we write most likely) you can only allow NULL by defining it as default value.
-> Yes I know ... by type-casting it's allowed everywhere ..

@gooh gooh closed this in bcd9aa8 Nov 11, 2012
@gooh
Copy link
Owner

gooh commented Nov 11, 2012

Thanks. I am not too happy about silently dropping the default value in these cases, but I guess it's better than having the Distiller terminate script execution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants