Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial revert of #17405, implement LAG_INIT #18978

Merged
merged 3 commits into from
May 28, 2024

Conversation

Sovexe
Copy link
Contributor

@Sovexe Sovexe commented May 17, 2024

About the PR

  • Partial revert of Adds some sweet optimisations, plus some minor ones. #17405
  • Reverts the sleep(-1) calls back to LAGCHECK calls
  • Implements new less aggressive LAG_INIT used by these procs to salvage some of the performance lost
  • Implements LAGCHECK_IF_LIVE(x) to allow local servers to keep using sleep(-1)

Why's this needed?

  • Attempting to reduce round start judder

@Sovexe Sovexe added C-Performance Targets performance enhancements A-Internal Deals with major internal, generally non-player facing code - e.g. types labels May 17, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2024
@goonstation-issuebot goonstation-issuebot added the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label May 17, 2024
@Laboredih123
Copy link
Contributor

Laboredih123 commented May 17, 2024

alas, if only there was a way to both go fast and to let people in quickly simultaneously. also not sure if 95 will be sufficient for local testing on weaker computers

@goonstation-issuebot goonstation-issuebot removed the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label May 28, 2024
@Sovexe Sovexe merged commit 619ca24 into goonstation:master May 28, 2024
23 checks passed
@Sovexe Sovexe deleted the partial-revert-#17405 branch May 28, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Internal Deals with major internal, generally non-player facing code - e.g. types C-Performance Targets performance enhancements size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants