-
Notifications
You must be signed in to change notification settings - Fork 6
feat: supports tiktok apify capabilities #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Noting here that the worker detection should actually see if said apify key currently "rents out" the required actors! Need to research a way to pull this off for
|
…o feat--tiktok-search
Since we'll have more of these (thinking of Reddit) we probably want to have a map of those that we're using (strongly typed, yada yada yada) and the capabilities they enable. We will probably end up having to make an Apify request for each actor. I wonder, if you make an invalid request (i.e. include no fields except for |
…o feat--tiktok-search
…o feat--tiktok-search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds TikTok search capabilities by integrating Apify actors for searching TikTok content. The implementation supports two new search methods: "searchbyquery" for searching by terms and "searchbytrending" for finding trending videos.
- Adds TikTok Apify client with two search actors for query and trending searches
- Refactors TikTok job handling to support multiple capabilities (transcription + search)
- Updates capability detection to include TikTok search when Apify API key is available
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/jobserver/jobserver.go | Updates TikTok job registration to use unified scraper |
| internal/jobs/webscraper.go | Fixes type assertion for web arguments |
| internal/jobs/twitter.go | Removes Apify validation code and fixes type assertion |
| internal/jobs/tiktokapify/client.go | New TikTok Apify client implementation |
| internal/jobs/tiktok_test.go | Adds comprehensive tests for TikTok search capabilities |
| internal/jobs/tiktok.go | Major refactor to support multiple TikTok job types |
| internal/jobs/stats/stats.go | Adds new TikTok-specific statistics |
| internal/capabilities/detector_test.go | Converts tests to Ginkgo format and adds Apify tests |
| internal/capabilities/detector.go | Adds Apify validation and TikTok search capability detection |
| go.mod | Updates tee-types dependency |
| Makefile | Updates test target for TikTok tests |
Comments suppressed due to low confidence (1)
internal/jobs/tiktok.go:139
- The code references
jobArgswhich is not defined in this function scope. This line should be part ofexecuteTranscriptionfunction, not the removed code section.
// Use the centralized type-safe unmarshaller
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mcamou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as soon as you resolve the merge conflicts :-) I updated tee-types so the current version is 1.1.12 (which should include the changes in your last PR)
What
Support the two new tiktok apify capabilities, searchbyquery and searchbytrending, both with their own unique actors!
Why
How are you supposed to transcribe tiktok videos if you can't search for them!?