added my solution #15
Conversation
Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in> added my solution fixed issue with blocking input added my solution Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in> added my solution
viveksyngh
force-pushed
the
my-solution
branch
from
8ebb5f1 to
764f0c2
Compare
| "math/rand" | ||
| ) | ||
|
|
||
| type Question struct { |
There was a problem hiding this comment.
It's a good idea to document an exported struct. You can use golint tool to tell you about these actions:
golint students/viveksyngh| if(err != nil) { | ||
| log.Fatal("Failed to parse CSV file.") | ||
| } | ||
| questions := make([]Question, 0) |
There was a problem hiding this comment.
Now you have successfully loaded your questionList, you have the required length. You can do this instead:
questions := make([]Question, len(questionList))
for i, question := range questionList {
if len(question) != 2 {
continue
}
questions[i] = Question{
strings.TrimSpace(question[0]),
strings.TrimSpace(question[1]),
}
}This way you don't allocate new array every time append is called. Also always check the input coming from outside world.
| return questions | ||
| } | ||
|
|
||
| func Quiz(questions []Question, timer *time.Timer) (score int){ |
There was a problem hiding this comment.
There is no need for named return, it's another allocation. If you simply name your function score it informs the reader what they expect.
| }() | ||
|
|
||
| select { | ||
| case <-timer.C: |
| return score | ||
| case userAnswer := <- answerChannel: | ||
| if(strings.TrimSpace(userAnswer) == question.answer) { | ||
| score += 1 |
| } | ||
|
|
||
| func randomize(questions []Question) []Question{ | ||
| n := len(questions) |
There was a problem hiding this comment.
You can do this too:
rand.Seed(time.Now().UnixNano())
for i := range questions {
j := rand.Intn(i + 1)
questions[i], questions[j] = questions[j], questions[i]
}or
rand.Seed(time.Now().UnixNano())
rand.Shuffle(len(questions), func(i, j int) {
questions[i], questions[j] = questions[j], questions[i]
})It's a good idea to seed your random generator otherwise the shuffle returns the same results every time you run the program, which defeats its purpose.
3 participants
Signed-off-by: Vivek Singh vivekkmr45@yahoo.in
added my solution