Fix non-deterministic JSON output for hype documents #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that JSON marshaling of hype documents produces deterministic, predictable output across multiple renders of the same content. Changes: - Document.MarshalJSON(): Copy and marshal snippet maps to ensure deterministic key ordering - Snippets.MarshalJSON(): Create new maps to leverage Go's json package automatic lexicographic key sorting - Element.JSONMap(): Convert syncx.Map attributes to regular map to ensure deterministic attribute ordering in JSON output - Parser.MarshalJSON(): Convert syncx.Map vars to regular map using Range() to ensure deterministic variable ordering Testing: - Added comprehensive JSON determinism tests to document_test.go: - Test_Document_JSON_Determinism: Basic document JSON determinism (10 runs) - Test_Document_JSON_Determinism_WithExecution: Determinism after execution - Test_Document_JSON_Determinism_RealWorld: Real-world scenario testing - Test_Parser_JSON_Determinism: Parser marshaling determinism - Test_Element_JSON_Determinism: Element marshaling determinism - Test_Snippets_JSON_Determinism: Snippets marshaling determinism - Benchmark_Document_JSON_Marshal: Performance benchmark All tests pass, confirming JSON output is now deterministic. Fixes: Non-deterministic JSON output when regenerating hype documents
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 12. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
corylanou
deleted the
claude/fix-hype-json-output-011CUoYdjQQucerK6d1X9DZB
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes non-deterministic JSON output when marshaling hype documents. Previously, rendering the same hype document multiple times would produce different JSON due to non-deterministic map iteration order.
Changes
Testing
Added comprehensive JSON determinism tests to document_test.go:
All tests pass ✅
Result
JSON output is now deterministic and predictable - rendering the same hype document multiple times will always produce identical JSON.