Feature : Add option to delete application #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmattheis
requested changes
Jan 4, 2021
Member
jmattheis
left a comment
jmattheis
left a comment
There was a problem hiding this comment.
Thanks for your contribution, remarks in subcomments.
| alert.setMessage("Are you sure?"); | ||
| alert.setPositiveButton( | ||
| "YES", | ||
| new DialogInterface.OnClickListener() { |
Member
There was a problem hiding this comment.
Simplify this with a lambda:
alert.setPositiveButton( "YES", (dialog, which) -> deleteApp(appId));
| if (item.getItemId() == R.id.action_delete_app) { | ||
| android.app.AlertDialog.Builder alert = new android.app.AlertDialog.Builder(this); | ||
| alert.setTitle(R.string.delete_app); | ||
| alert.setMessage("Are you sure?"); |
Member
There was a problem hiding this comment.
This message and yes/no should be added to strings.xml.
| } | ||
|
|
||
| private void deleteApp(Long appId) { | ||
| Thread thread = |
Member
There was a problem hiding this comment.
You can use the async version of the api call instead of creating a thread for this:
private void deleteApp(Long appId) {
ApiClient client =
ClientFactory.clientToken(settings.url(), settings.sslSettings(), settings.token());
client.createService(ApplicationApi.class)
.deleteApp(appId)
.enqueue(
Callback.callInUI(
this,
(ignored) -> refreshAll(),
(e) -> Utils.showSnackBar(this, "Could not delete app")));
}"Could not delete app" should be put into strings.xml
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this feature can be useful for the main version I'm PR here. It will be used on the unifiedpush branch to unregister app too
If gotify shows all messages, nothing change.
If we select an app, the right corner menu add "Delete this application" option which shows a dialog to acknowledge to delete the application.
If yes is selected it deletes the app and refresh.
else it does nothing