Skip to content

Conversation

@schwma
Copy link
Contributor

@schwma schwma commented Nov 8, 2018

  • Fix persistent notification causing vibration and audio alerts (for example when loosing connection to server)
  • Allow message notifications to pop up as heads-up notifications
  • Add LED light to message notifications
  • Prevent duplicate notification sounds from message group notification
  • Add message notification accent color (set to colorPrimary)

@jmattheis jmattheis self-requested a review November 8, 2018 18:31
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, the commits are structured really well and are easy to understand!

Most of the stuff should already be configurable in the android notification settings for the application (right?) tho the used defaults weren't that good. So good change.

I've only one nitpick. The foreground notification doesn't have the blue-ish color that the other notifications have.

@jmattheis jmattheis merged commit 3c8b500 into gotify:master Nov 9, 2018
@jmattheis
Copy link
Member

Fixed my nitpick in #20

@schwma
Copy link
Contributor Author

schwma commented Nov 11, 2018

Thanks for the merge!

Thats true! However, some notification settings can't be changed on stock Android and most default ROMs without installing additional apps. For example I can't adjust the notification LED settings on my device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants