Update .service, use upstream config, fix HOME. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmattheis
reviewed
Mar 10, 2020
|
There are still some issues: Tests fail when there is a I'm not sure if I want the output in the journal since it includes the timestamp and is taking a lot of place. Is there a better logging output option if should we just write logs to a separate file like /var/log/gotify.log? |
jmattheis
added a commit
to gotify/server
that referenced
this pull request
Mar 11, 2020
Our config test ensures that the correct values will be extracted from the config file and environment variables. A globally defined config may change settings which are expected to have default values. See gotify/server-aur-git#2 (comment)
|
Yeah, we could add a redirect to file via systemd. Maybe /var/log/gotify/server.log because we also have a cli app which could log in the future. The test failure should be fixed with gotify/server#279 in the meantime we should disable check or exclude the config package. |
jmattheis
reviewed
Mar 11, 2020
jmattheis
reviewed
Mar 11, 2020
jmattheis
added a commit
to gotify/server
that referenced
this pull request
Mar 11, 2020
Our config test ensures that the correct values will be extracted from the config file and environment variables. A globally defined config may change settings which are expected to have default values. See gotify/server-aur-git#2 (comment)
- Add .install file to warn about default user - Dropped tmpfiles.d in favor of (recommended) ConfigurationDirectory, LogsDirectory, StateDirectory - Added `etc/gotify/config.yml` to `backup=()` - Build UI with `NODE_ENV=production` - Install config with 644 instead of 640 - Use absolute paths inside config - Create `gotify` user without home - Use `UMask=0027` instead of `0077` in service file - Add `emptydirs` to `options=()`
jmattheis
approved these changes
Mar 12, 2020
jmattheis
added a commit
to gotify/server
that referenced
this pull request
Mar 14, 2020
Our config test ensures that the correct values will be extracted from the config file and environment variables. A globally defined config may change settings which are expected to have default values. See gotify/server-aur-git#2 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change removes local
config.ymland used the (patched) example config from upstream instead.Note: paths inside
/var/libchanged. (Need migration script?)Also a slightly hardened systemd service file, socket still missing. Let me know what matters in the end.