Skip to content

Conversation

jmattheis
Copy link
Member

  • fix a bug where messages were not deleted correctly
  • replace mocks (because they suck) with an in memory sqlite database

@codecov-io
Copy link

codecov-io commented Mar 24, 2018

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #36   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     24    +3     
  Lines         538    612   +74     
=====================================
+ Hits          538    612   +74
Impacted Files Coverage Δ
api/stream/stream.go 100% <ø> (ø)
api/message.go 100% <ø> (ø) ⬆️
auth/password/password.go 100% <ø> (ø)
config/config.go 100% <ø> (ø) ⬆️
api/stream/client.go 100% <ø> (ø)
mode/mode.go 100% <100%> (ø) ⬆️
api/internalutil.go 100% <100%> (ø) ⬆️
database/database.go 100% <100%> (ø) ⬆️
test/asserts.go 100% <100%> (ø)
auth/authentication.go 100% <100%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d19b5...c74e120. Read the comment docs.

Till now only the ApplicationID got remove from the message, therefore
the message was still in the database but not visible for the user.
@jmattheis jmattheis merged commit a6ff239 into master Mar 25, 2018
@jmattheis jmattheis deleted the improve-tests branch March 25, 2018 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants