Message paging #45
Merged
Message paging #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 24 24
Lines 692 735 +43
=====================================
+ Hits 692 735 +43
Continue to review full report at Codecov.
|
Using the button in edge resulted in a page reload and therefore you couldn't login.
The list cached the height while switching between applications. We fix this with the use of the key property, that means that react will not reuse the component and make a new one. see https://reactjs.org/docs/reconciliation.html
jmattheis
force-pushed
the
message-paging
branch
from
c40d68a to
c8a1a56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34