chore: configure golangci-lint #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-suhas
force-pushed
the
configure-golangci-lint
branch
from
ae56191 to
83ba3dd
Compare
- There are two versions of the configuration file added - .golangci.toml and .golangci-prod.toml. The former is for local development and testing, while the latter is for continuous integration (CI). The difference is that the prod version includes some more intensive checks that may take longer to run, but are important for ensuring code quality and security. - Manage tools used to build, lint and format code using tools/go.mod. Set up the Makefile to use locally built versions of the tools using tools/go.mod. - Use remote plugin for buf build and use the latest available version. - Update the golang-lint-action workflow to use latest version of golangci-lint.
sudo-suhas
force-pushed
the
configure-golangci-lint
branch
from
83ba3dd to
0fe31e2
Compare
haveiss
reviewed
May 31, 2023
haveiss
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the linter reports errors only for code that was changed since previous commit even with the updated configuration. This should allow us to gradually address all linter issues.