Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Upload coverage artifact
uses: actions/upload-artifact@v4
with:
name: coverage
name: coverage-${{ strategy.job-index }}
path: coverage.out

pretest:
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:
- name: Upload coverage artifact
uses: actions/upload-artifact@v4
with:
name: coverage-plugins
name: coverage-plugins-${{ strategy.job-index }}
path: coverage-plugins*.out

coverage:
Expand All @@ -79,11 +79,11 @@ jobs:
- name: Download coverage
uses: actions/download-artifact@v4
with:
name: coverage
name: coverage-${{ strategy.job-index }}
- name: Download plugins coverage
uses: actions/download-artifact@v4
with:
name: coverage-plugins
name: coverage-plugins-${{ strategy.job-index }}
- name: Install goveralls and send coverage
env:
COVERALLS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
36 changes: 24 additions & 12 deletions plugins/sinks/compass/sink.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"github.com/goto/meteor/utils"
"github.com/goto/salt/log"
"github.com/pkg/errors"
"golang.org/x/sync/errgroup"
"google.golang.org/protobuf/encoding/protojson"
"google.golang.org/protobuf/types/known/anypb"
)
Expand Down Expand Up @@ -91,22 +92,33 @@ func (s *Sink) Init(ctx context.Context, config plugins.Config) error {
}

func (s *Sink) Sink(ctx context.Context, batch []models.Record) error {
for _, record := range batch {
asset := record.Data()
s.logger.Info("sinking record to compass", "record", asset.GetUrn())
if len(batch) == 0 {
return nil
}

compassPayload, err := s.buildCompassPayload(asset)
if err != nil {
return fmt.Errorf("build compass payload: %w", err)
}
if err = s.send(ctx, compassPayload); err != nil {
return fmt.Errorf("send data: %w", err)
}
errGroup := errgroup.Group{}
errGroup.SetLimit(len(batch))

s.logger.Info("successfully sinked record to compass", "record", asset.GetUrn())
for _, record := range batch {
record := record
errGroup.Go(func() error {
asset := record.Data()
s.logger.Info("sinking record to compass", "record", asset.GetUrn())

compassPayload, err := s.buildCompassPayload(asset)
if err != nil {
return fmt.Errorf("build compass payload: %w", err)
}
if err := s.send(ctx, compassPayload); err != nil {
return fmt.Errorf("send data: %w", err)
}

s.logger.Info("successfully sinked record to compass", "record", asset.GetUrn())
return nil
})
}

return nil
return errGroup.Wait()
}

func (*Sink) Close() error { return nil }
Expand Down
Loading