Skip to content

refactor: enhance log with task id #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

refactor: enhance log with task id #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
896ad4c
refactor: enhance log with task id
deryrahman Apr 16, 2025
caf5f2b
fix: remove comma to avoid broken url
deryrahman Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mc2mc/internal/client/odps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func (c *odpsClient) ExecSQL(ctx context.Context, query string, additionalHints
err = e.Join(err, taskIns.Terminate())
return errors.WithStack(err)
}
c.logger.Info(fmt.Sprintf("taskId: %s, log view: %s, hints: (%s)", taskIns.Id(), url, getHintsString(hints)))
c.logger.Info(fmt.Sprintf("taskId: %s, log view: %s , hints: (%s)", taskIns.Id(), url, getHintsString(hints)))

// wait execution success
select {
Expand Down Expand Up @@ -118,6 +118,7 @@ func (c *odpsClient) wait(taskIns *odps.Instance) <-chan error {
defer close(errChan)
err := c.retry(taskIns.WaitForSuccess)
if err != nil {
err := errors.Wrap(err, fmt.Sprintf("task instance %s failed", taskIns.Id()))
errChan <- errors.WithStack(err)
}
c.logger.Info(fmt.Sprintf("task instance %s finished with status: %s", taskIns.Id(), taskIns.Status()))
Expand Down
Loading