Skip to content

fix(mc2mc): use copied additionalHints in (Client).ExecuteFn #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

fix(mc2mc): use copied additionalHints in (Client).ExecuteFn #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions mc2mc/internal/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,16 @@ func (c *Client) Close() error {

func (c *Client) ExecuteFn(id int) func(context.Context, string, map[string]string) error {
return func(ctx context.Context, query string, additionalHints map[string]string) error {
// execute query with odps client
c.logger.Info(fmt.Sprintf("[sequence: %d] query to execute:\n%s", id, query))
// Merge additionalHints with the id
if additionalHints == nil {
additionalHints = make(map[string]string)
// Create local copy of additionalHints with sequence hint
hints := make(map[string]string, len(additionalHints)+1)
for k, v := range additionalHints {
hints[k] = v
}
additionalHints[SqlScriptSequenceHint] = fmt.Sprintf("%d", id)
hints[SqlScriptSequenceHint] = fmt.Sprintf("%d", id)

if err := c.OdpsClient.ExecSQL(ctx, query, additionalHints); err != nil {
// execute query with odps client
if err := c.OdpsClient.ExecSQL(ctx, query, hints); err != nil {
return errors.WithStack(err)
}

Expand Down
Loading