Skip to content

Conversation

@jamesdh
Copy link
Contributor

@jamesdh jamesdh commented Jul 11, 2019

Fixes #122. Pretty straightforward. Not many changes required.

Summary:

  • Upgrade Gradle Wrapper to 5.1.1 (matching newly generated Grails 4.x projects)
  • Upgraded Hibernate from 5.2.17 to 5.4.0 (matching Grails 4.x projects...)
  • Upgraded GORM Hibernate 5 plugin from 6.1.9 to 7.0.0 (matching...)
  • Removed obsoleted 'org.grails:grails-plugin-testing` dependency
  • Added a simple Dockerfile + Makefile to make running integration tests dead simple

dependencies {
classpath "org.grails:grails-gradle-plugin:$grailsVersion"
classpath "org.grails.plugins:hibernate5:${gormVersion - '.RELEASE'}"
classpath "org.grails.plugins:hibernate5:7.0.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better use ${gormVersion} instead of 7.0.0, you already have gormVersion=7.0.2.RELEASE in the gradle.properties

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhuravskiy the hibernate plugin isn't released in lock-step w/ the gorm plugin. The latest version available of org.grails.plugins:hibernate5 is 7.0.1 (see here). So it seems it may have been a mistake to depend on gormVersion for defining that. I'm guessing that was a relic from when the GORM plugins were organized differently, and shouldn't apply anymore.

Therefore, I just used the same versions as given in a fresh Grails 4.0 project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhuravskiy Thank you for reviewing!

@zhuravskiy
Copy link

zhuravskiy commented Jul 15, 2019

Hi @ilopmar. Are you have plans to merge this and release grails-postgresql-extensions for grails 4.0.0 ?

@jamesdh
Copy link
Contributor Author

jamesdh commented Jul 22, 2019

Pinging @ilopmar. Is there anything I can do to movet his along? E.g. fix up the documentation regarding 4.0 etc?

@ilopmar
Copy link
Collaborator

ilopmar commented Jul 22, 2019

Thank you both of you for the PR. I've been on vacations and I need a few more days to check everything and release a new version.

@ilopmar ilopmar merged commit 3fc6c8e into gpc:master Jul 29, 2019
@ilopmar
Copy link
Collaborator

ilopmar commented Jul 29, 2019

I have released version 7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Grails 4.x

3 participants