-
Notifications
You must be signed in to change notification settings - Fork 62
Update to Grails 4.0.0 Final #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Postgres image is built w/ hstore support ready to go
| dependencies { | ||
| classpath "org.grails:grails-gradle-plugin:$grailsVersion" | ||
| classpath "org.grails.plugins:hibernate5:${gormVersion - '.RELEASE'}" | ||
| classpath "org.grails.plugins:hibernate5:7.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better use ${gormVersion} instead of 7.0.0, you already have gormVersion=7.0.2.RELEASE in the gradle.properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhuravskiy the hibernate plugin isn't released in lock-step w/ the gorm plugin. The latest version available of org.grails.plugins:hibernate5 is 7.0.1 (see here). So it seems it may have been a mistake to depend on gormVersion for defining that. I'm guessing that was a relic from when the GORM plugins were organized differently, and shouldn't apply anymore.
Therefore, I just used the same versions as given in a fresh Grails 4.0 project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, I asked about it here: https://grails.slack.com/archives/C0J9Y5PHU/p1562866992014200
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhuravskiy Thank you for reviewing!
|
Hi @ilopmar. Are you have plans to merge this and release |
|
Pinging @ilopmar. Is there anything I can do to movet his along? E.g. fix up the documentation regarding 4.0 etc? |
|
Thank you both of you for the PR. I've been on vacations and I need a few more days to check everything and release a new version. |
|
I have released version |
Fixes #122. Pretty straightforward. Not many changes required.
Summary: