Skip to content

Conversation

@ilopmar
Copy link
Collaborator

@ilopmar ilopmar commented Jul 21, 2014

First version of the json support for Hibernate 4

@ilopmar
Copy link
Collaborator Author

ilopmar commented Jul 21, 2014

@Alotor. Please do not merge it yet.

I'm thinking about supporting both Map and JsonObject using ParameterizedType as you did with ArrayType. What do you think about it?

@Alotor
Copy link
Collaborator

Alotor commented Jul 21, 2014

To your question I don't think you should parametrize... maybe two different user types it's better.

One question. Which operations are you planning to support?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.23%) when pulling a9cbfd6 on json_support_hibernate4 into 8a5243c on master.

@ilopmar
Copy link
Collaborator Author

ilopmar commented Jul 21, 2014

I don't know which operators we should support. I have to read about json in Pg and do some tests. Do you have any suggestions?

I'll create a new UserType for JsonObject, update the documentation and do a push -f to this branch.

@Alotor
Copy link
Collaborator

Alotor commented Jul 21, 2014

http://www.postgresql.org/docs/9.3/static/functions-json.html

Maybe we can use these functions to implement "has field" and "contains" (only to check if a field has a specific value)

@ilopmar
Copy link
Collaborator Author

ilopmar commented Jul 21, 2014

Ok, I'll try it :-)

@ilopmar
Copy link
Collaborator Author

ilopmar commented Jul 23, 2014

@Alotor ready to merge if you want it. Then I'll release 4.1.0 and backport the changes to 3.x branch.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.13%) when pulling ed7470f on json_support_hibernate4 into 8a5243c on master.

Alotor added a commit that referenced this pull request Jul 23, 2014
@Alotor Alotor merged commit 8c3a805 into master Jul 23, 2014
@Alotor
Copy link
Collaborator

Alotor commented Jul 23, 2014

Great! looks awesome :)

@ilopmar ilopmar mentioned this pull request Jul 24, 2014
@ilopmar ilopmar deleted the json_support_hibernate4 branch July 25, 2014 14:16
@ilopmar ilopmar mentioned this pull request Jul 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants