cleanup #54
Merged
cleanup #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you very much for the PR. I'll try to merge it in the following days :-) |
Collaborator
|
Hello Burt and Happy New year 😄 Why did you remove the "@OverRide" annotations? We wanted to put them so if the Hibernate API changes the compiler warns us that the method is not implemented. |
Member
Author
|
I only removed @OVERRIDES from methods implementing interface methods. This is optional and I've never understood why anyone does this. If you fail to implement a method, there are better ways to discover that, e.g. your class won't compile :) Feel free to revert any change that I made - consider everything just a suggestion. |
ilopmar
added a commit
that referenced
this pull request
Jan 11, 2015
Collaborator
|
Thank you Burt for your cleanup. I've reverted only some minor changes. Regards, Iván. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI - in HstoreHelper.asStatement() the "key" variable isn't used.