V7.0.x prepare for release #49
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request is preparing the rendering plugin for the 7.0.x release with comprehensive cleanup and modernization efforts. The PR updates the plugin to be compatible with Grails 7.0.0-RC2, removes outdated artifacts, and restructures the project for better maintainability.
Key changes include:
- Updated the plugin to support Grails 7.0.0-RC2 instead of 3.0+
- Removed legacy files and folders that are no longer needed
- Added a new example application and comprehensive CI/CD workflows
Reviewed Changes
Copilot reviewed 105 out of 132 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/groovy/grails/plugins/rendering/RenderingGrailsPlugin.groovy | Updated Grails version requirement and plugin metadata URLs |
| src/main/groovy/grails/plugins/rendering/document/RenderEnvironment.groovy | Added Environment check to conditionally initialize test environment |
| grails-app/services/grails/plugins/rendering/RenderingService.groovy | Added type annotations and modernized for Grails 7 compatibility |
| example/ | Added new example application demonstrating plugin usage |
| .github/workflows/ | Added modern CI/CD workflows for testing and releasing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 105 out of 132 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
There's an open PR to switch to openpdf instead of itext, have you considered this? |
|
@jdaugherty I probably should. Thank you for bringing that to my attention |
… used * Did some extra refactorings, added more @CompileStatic * ITextRenderer from the latest flyingsaucer handles inlined images in .gsps
It was actually already using OpenPDF, but not the latest versions. Got me down a rabbit hole, but I surfaced again and now I think it is ready. |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 115 out of 142 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/groovy/grails/plugins/rendering/document/RenderEnvironment.groovy
Show resolved
Hide resolved
Cleaned up, preparing for release