Stage2 l1 matching #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (int ibx = l1tBX->getFirstBX(); ibx <= l1tBX->getLastBX(); ++ibx) | ||
| bxIdxs.push_back(l1tBX->end(ibx) - l1tBX->begin()); | ||
| } | ||
| else { |
There was a problem hiding this comment.
secondo me sarebbe piu' leggibile mettendo le graffe attorno al for, e mettere la graffa prima dell'else alla stessa riga dell'else, altrimenti potrebbe sembrare che la graffa a 132 chiuda il for
There was a problem hiding this comment.
Corretto, scusami e' che di solito scrivo + largo (mandando a capo tutte le graffe) e avevo compattato secondo il tuo stile, ma l'ho fatto male .
Conflicts: L1Trigger/L1TMuonOverlap/interface/AngleConverter.h L1Trigger/L1TMuonOverlap/interface/OMTFConfiguration.h L1Trigger/L1TMuonOverlap/plugins/OMTFPatternMaker.cc L1Trigger/L1TMuonOverlap/src/AngleConverter.cc L1Trigger/L1TMuonOverlap/src/GhostBuster.cc L1Trigger/L1TMuonOverlap/src/GoldenPattern.cc L1Trigger/L1TMuonOverlap/src/OMTFConfigMaker.cc L1Trigger/L1TMuonOverlap/src/OMTFConfiguration.cc L1Trigger/L1TMuonOverlap/src/OMTFProcessor.cc L1Trigger/L1TMuonOverlap/src/OMTFReconstruction.cc L1Trigger/L1TMuonOverlap/src/OMTFResult.cc L1Trigger/L1TMuonOverlap/src/OMTFSorter.cc L1Trigger/L1TMuonOverlap/src/OMTFinput.cc L1Trigger/L1TMuonOverlap/src/OMTFinputMaker.cc L1Trigger/L1TMuonOverlap/src/XMLConfigReader.cc L1Trigger/L1TMuonOverlap/src/XMLConfigWriter.cc
…rmawre configurations, other for faster changing patterns data.
* remove split of the OMTF configuration into two DB records (maybe put back if needed)
(it was transparent, as resuiltig value was assigne to int, resulting back in -1) * set missing HwSignValid to always true
…e Bmtf unpacker; For 2015 Customise L1TReEmul(MC)FromRAW2015 from L1T input Digis, except for HcalTP.
…ion. It belongs (and is) in L1Trigger.Configuration.CaloTriggerPrimitives_cff and should not be called in multiple locations.
…rigger.Configuration.CaloTriggerPrimitives_cff when ReEmul. Add simEcal/HcalTP to 2016 ReEmul
…simEcalTPs and HcalTP digis
Changes for O2O deployment and monitoring
improve TkMaps
…-2016-2015_CMSSW808 Adding L1REPACK:FullMC workflow to run on RAW of MC (80x)
Monitor CASTOR table data (80X)
Restore overflow check for et and ht sums
…uIsoOpt-21-80x MCprod l1t Tau Iso Option-21 80x
…kport CTPPS: new CondFormats related to TOTEM RP raw data and digi - backport of cms-sw#13838
HLT development in May (80X)
…elClusterProducer80 fix crash in case Limit on the number of clusters is really exceeded.
TH1ClusterCharge and TH1ClusterStoNCorr plots per ring
…ol-fix0-80X Fix for handling copy of offline synchronized tags
Prescale access for stage-2 environment (80X)
…16/cleanupRawToDigi_Data cleanup RawToDigi redefinition of already loaded from RawToDigi_cff (bp of cms-sw#14675)
…tor<reco::Candidate,true>)
gpetruc
pushed a commit
that referenced
this pull request
Jun 17, 2016
Heppy: one more WP for tau ID (80X)
gpetruc
pushed a commit
that referenced
this pull request
Oct 28, 2016
…un2-gem19 Fixes to DIGI,L1,RECO and Validation steps with GE21
gpetruc
pushed a commit
that referenced
this pull request
Aug 16, 2017
added new paths for reference method
gpetruc
pushed a commit
that referenced
this pull request
Oct 29, 2019
…ciator AM 10_6_X factorize filter and associator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I create it as a dummy PR here on my github so I can make some line-by-line comments