Fix: Fix creation bugs to make slug unique. #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrongMonkey
commented
Aug 14, 2024
| } | ||
| } | ||
|
|
||
| export async function getNewScriptName() { |
There was a problem hiding this comment.
The logic of magically delecting assistant name is removed. Right now it defaults to New Assistant where user can have multiple.
StrongMonkey
commented
Aug 14, 2024
| }) | ||
| }) | ||
| const defaultName = "New Assistant"; | ||
| const slug = defaultName.toLowerCase().replace(" ", "-") + "-" + Math.random().toString(36).substring(2, 7); |
There was a problem hiding this comment.
The logic of creating a unique slug per assistant by appending random 5 charaters.
StrongMonkey
commented
Aug 14, 2024
| id: scriptId, | ||
| } | ||
| // Only update slug when displayName has changed | ||
| if (existing?.displayName !== root.name) { |
There was a problem hiding this comment.
In here we only update the slug when displayName has changed.
StrongMonkey
commented
Aug 14, 2024
|
|
||
| return ( | ||
| <div className={`h-full w-full ${className}`}> | ||
| {showAssistantName && <h1 |
There was a problem hiding this comment.
Added the title where chat can have assitant name on the top
…ssues Signed-off-by: Daishan Peng <daishan@acorn.io>
StrongMonkey
force-pushed
the
fix-creation-bug
branch
from
7dd82ec to
61c93e5
Compare
thedadams
approved these changes
Aug 14, 2024
drpebcak
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes creating assistance where slug has to be unique. It makes sure user can create assistance with the same name.
It also fixes other bugs where page is unnecessarily rendered that causes other network traffic.
Ignore all the formatter issues, i am going to have a separate PR after conference to add prettier and eslint config to the project.
#141