fix: ensure app dirs exist #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
- Ensure the WORKSPACE_DIR and SCRIPTS_PATH directories are created before attempting to use them. - Refactor misc related code Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
njhale
commented
Jul 18, 2024
| const files = await fs.readdir(SCRIPTS_PATH()); | ||
| const gptFiles = files.filter(file => file.endsWith('.gpt')); | ||
| const scriptsPath = SCRIPTS_PATH() | ||
| await fs.mkdir(scriptsPath, {recursive: true}) |
There was a problem hiding this comment.
Note: fs.mkdir doesn't throw an error if the directory already exists when the recursive: true option is passed.
Comment on lines
-133
to
-143
| export async function updateThread(id: string, thread: Thread) { | ||
| const threadsDir = THREADS_DIR(); | ||
| const threadPath = path.join(threadsDir,id); | ||
|
|
||
| if (thread.state) await fs.writeFile(path.join(threadPath, STATE_FILE), thread.state); | ||
| if (thread.meta) { | ||
| const existingMeta = await fs.readFile(path.join(threadPath, META_FILE), "utf-8"); | ||
| const mergedMeta = { ...JSON.parse(existingMeta), ...thread.meta }; | ||
| await fs.writeFile(path.join(threadPath, META_FILE), JSON.stringify(mergedMeta)); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Seems like this isn't used
| @@ -1,4 +1,6 @@ | |||
|
|
|||
| export const dynamic = 'force-dynamic' // defaults to autover' | |||
| import {NextResponse} from "next/server"; | |||
There was a problem hiding this comment.
My linter was complaining about Response.json not existing here.
There was a problem hiding this comment.
Fair, it is auto imported I believe. Also this whole API section can get removed soonish. It isn't used right now, not important but just adjacent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the WORKSPACE_DIR and SCRIPTS_PATH directories are created before attempting to use them and refactor some misc related code.