feat: make save and save as work with knowledge #370
Conversation
| } | ||
| > | ||
| {knowledgeFiles.map((f) => ( | ||
| <DropdownSection |
There was a problem hiding this comment.
Most of this is getting the counts displayed correctly and adding the "show all" functionality when there is more than 10 files.
There was a problem hiding this comment.
I don't know if we should add max height and make it scrollable. Show like 100 files will still be too long if user clicked show all,
There was a problem hiding this comment.
Not sure what you are suggesting here. The max height and scroll works for lots of files.
There was a problem hiding this comment.
I am suggesting adding a max height and make it scrollable. Show all will still mess up with dropdown if there are a lot of files.
There was a problem hiding this comment.
Oh, cool. That is already here. So we're good!
There was a problem hiding this comment.
Here is an example.
After I took those screenshots, I made the "Show All" text smaller.
components/chat/useChatSocket.tsx
Outdated
| ); | ||
|
|
||
| const handleToolAdjusted = (tools: string[]) => { | ||
| const handleToolChange = ( |
There was a problem hiding this comment.
I will probably make this an async function. .then syntax is too hard to use and read.
| const [assistantExpanded, setAssistantExpanded] = useState(false); | ||
| const [threadExpanded, setThreadExpanded] = useState(false); | ||
|
|
||
| function refreshKnowledgeFiles(isOpen: boolean) { |
There was a problem hiding this comment.
Same here..make whole async if possible
| } | ||
| > | ||
| {knowledgeFiles.map((f) => ( | ||
| <DropdownSection |
There was a problem hiding this comment.
I don't know if we should add max height and make it scrollable. Show like 100 files will still be too long if user clicked show all,
Signed-off-by: Donnie Adams <donnie@acorn.io>
3 participants
No description provided.