pull gateway config from GitHub #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
njhale
requested changes
Aug 10, 2024
server/app.mjs
Outdated
| const configPath = gptscriptConfigPath(); | ||
|
|
||
| fs.readFile(configPath, 'utf8', (err, data) => { | ||
| fs.readFile(configPath, 'utf8', async (err, data) => { |
There was a problem hiding this comment.
We want initGPTScriptConfig to block server startup until the file is created. Won't switching this to async mean that initGPTScriptConfig can return before the file is created?
There was a problem hiding this comment.
Idk but I'll remove it and handle everything with .then.
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
Signed-off-by: Grant Linville <grant@acorn.io>
njhale
requested changes
Aug 10, 2024
Signed-off-by: Grant Linville <grant@acorn.io>
njhale
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this locally with an interval of 30s and it works the way it should. I set the interval here to 30m. Let me know if it should be different.
Sorry for all the random whitespace changes, lol. I guess my WebStorm settings caused that.