fix: auto allow/deny tool run requests on dynamic tool add/remove #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
changed the title
njhale
force-pushed
the
fix/threads-w-dynamic-tools
branch
from
3b757fe to
474eab5
Compare
g-linville
approved these changes
Aug 10, 2024
When tools are added or removed, the socket server runs the script to regenerate tool definitions. Now that the gateway-provider has been incorporated as the default model provider, this logic gets stuck waiting for user confirmation, and leads to the user getting stuck on a loading screen. This same logic also means that if the LLM attempts to call any other tool -- which is prone to doing without being asked to -- we run into the same problem (e.g. the second tool add hangs forever bug). To fix this, add a handler to the tool run that auto-approves providers and auto-denies requests to run any other tool. Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
njhale
force-pushed
the
fix/threads-w-dynamic-tools
branch
from
474eab5 to
d6fd2c2
Compare
thedadams
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tools are added or removed, the socket server runs the script to
regenerate tool definitions. Now that the gateway-provider has been
incorporated as the default model provider, this logic gets stuck
waiting for user confirmation, and leads to the user getting stuck on a
loading screen. This same logic also means that if the LLM attempts to
call any other tool -- which it's prone to doing without being asked to --
we run into the same problem (e.g. the second tool add hangs forever
bug).
To fix this, add a handler to the tool run that auto-approves providers
and auto-denies requests to run any other tool.
Addresses #110