Add news permalinks #97
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A second attempt to implement #90 (after #91 seems to have maybe done something a bit different than intended, I'm guessing maybe changed a bit too much?)
This is mostly all Copilot generated, not sure what the policy is on generated vs hand-written code, but there was a lot of hand holding from me.
Essentially:
news/:post_id
, it automatically scrolls to that articleThe most annoying part was that there's several stages of loading of the content. Initially, no content is loaded. Then, some of the content is loaded, but the markdown still needs to be rendered. Finally, the markdown is rendered, but images might still be loading. So the majority of the non-test code is trying to handle this.
How did I test:
Screenshot (it looks the same as before, just see the newly updated URL in the address bar!):

@msaroufim @yangw-dev