-
Notifications
You must be signed in to change notification settings - Fork 99
Add tests on createBindGroupLayout() with new storage texture accesses #3186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kangz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ben-clayton I'm surprised that Jiawei had to regenerate the cache here, is that expected?
So the hashes will change if there's files modified that could impact the generation of the cache files. The fact the files have actually changed is likely due to differences in NodeJS versions. This is discussed here:
It would be good to try keeping the CTS developers on the same version of the NodeJS, and avoiding no-op regeneration like this. |
|
Created #3187 to try to prevent continual cache regeneration. |
jiangzhaoming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks
| .desc( | ||
| ` | ||
| Test that a validation error is generated if the format doesn't support the storage usage. | ||
| Test that a validation error is generated if the format doesn't support the storage usage. A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the "storage usage" mentioned here and in kTextureFormatInfo actually means supporting "write-only" or "read-only" STORAGE_BINDING in the spec, and the new added readWriteStorage means "read-write" STORAGE_BINDING.
Luckily formats that support readWriteStorage is a subset of formats that support storage (very reasonable), but I am not sure if we need to rename storage or make a comment somewhere?
Co-authored-by: jzm-intel <zhaoming.jiang@intel.com>
Co-authored-by: jzm-intel <zhaoming.jiang@intel.com>
Kangz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just don't understand while all these new files where created.
This patch adds tests on the use of new storage texture accesses
read-onlyandread-writein the creation of bind grouplayouts.
This patch also upgrades the version of @webgpu/types to the latest one to support these two storage texture accesses.
Note that right now this test can only pass when Chromium is launched with
--enable-dawn-features=allow_unsafe_apis.Issue: #3078
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.