Skip to content

Conversation

@greggman
Copy link
Contributor

Spec changed so that usage of rgXXX format textures as storage textures should generate a shader module creation error.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Spec changed so that usage of rgXXX format textures
as storage textures should generate a shader module
creation error.
@greggman greggman force-pushed the compat-rgXXX-fixes branch from d54744b to b0adb80 Compare June 20, 2024 23:44
@greggman greggman requested a review from jrprice June 20, 2024 23:46
Copy link
Contributor

@jrprice jrprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greggman greggman merged commit 85678b2 into gpuweb:main Jun 21, 2024
@greggman greggman deleted the compat-rgXXX-fixes branch June 21, 2024 00:36
const { format, access, comma } = t.params;
const info = kTextureFormatInfo[format];
// bgra8unorm is considered a valid storage format at shader compilation stage
const isFormatValid =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into this issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants