Add copyBufferToTexture and copyTextureToBuffer validation tests #4420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greggman
force-pushed
the
copy-t2b-b2t-alignment
branch
from
51a094a to
c760cd1
Compare
In particular test that for copyBufferToTexture, and copyTextureToBuffer * bytesPerRow must be a multiple of 256 * offset must be a multiple of bytesPerBlock * the last row does not need to be a multiple of 256 In other words, If the copy size is 4x2 of a r8unorm texture that's 4 bytes per row. To get from row 0 to row 1 in the buffer, bytesPerRow must be a multiple of 256. But, the size requirement for the buffer is only 256 + 4, not 256 * 2 * origin.x must be a multiple of blockWidth * origin.y must be a multiple of blockHeight * copySize.width must be a multiple of blockWidth * copySize.height must be a multiple of blockHeight
greggman
force-pushed
the
copy-t2b-b2t-alignment
branch
from
c760cd1 to
6c9228a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular test that for copyBufferToTexture, and copyTextureToBuffer
bytesPerRow must be a multiple of 256
offset must be a multiple of bytesPerBlock
the last row does not need to be a multiple of 256
In other words, If the copy size is 4x2 of a r8unorm texture that's 4 bytes per row. To get from row 0 to row 1 in the buffer, bytesPerRow must be a multiple of 256. But, the size requirement for the buffer is only 256 + 4, not 256 * 2
origin.x must be a multiple of blockWidth
origin.y must be a multiple of blockHeight
copySize.width must be a multiple of blockWidth
copySize.height must be a multiple of blockHeight