Skip to content

Remove duplicate ast imports #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2020
Merged

Remove duplicate ast imports #77

merged 3 commits into from
Feb 26, 2020

Conversation

@smkhalsa
Copy link
Member

@smkhalsa smkhalsa commented Feb 25, 2020

Fixes #73.

Looks like it was a very simple fix.

@smkhalsa smkhalsa requested a review from klavs February 25, 2020 21:45
klavs
klavs approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@klavs klavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

klavs
klavs suggested changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@klavs klavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smkhalsa would you be able to rebase on add-typename branch, bump the versions and add a changelog entry?

@smkhalsa smkhalsa force-pushed the remove-duplicate-ast-imports branch from a611f64 to 6db41c8 Compare February 25, 2020 22:39
@smkhalsa
Copy link
Member Author

smkhalsa commented Feb 25, 2020

@klavs done

@smkhalsa smkhalsa requested a review from klavs February 25, 2020 22:41
@klavs klavs merged commit 0f67d76 into gql-dart:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@klavs klavs klavs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[gql_build] duplicate ast imports

2 participants

@smkhalsa @klavs