Conversation
Collaborator
|
Looks great! |
gr2m
commented
Mar 15, 2022
Owner
Author
gr2m
left a comment
gr2m
left a comment
There was a problem hiding this comment.
Now that we offer custom matching functions, there is a chance that multiple fields / field options can be matched, which I'd say should throw a helpful error. But we can address this in a follow up issue, I'd say it's an edge case and shouldn't block this feature from being released
mikesurowiec
approved these changes
Mar 15, 2022
| 1. `projectFieldName` | ||
| 2. `userFieldName` | ||
|
|
||
| Both are strings. Both arguments are lower-cased and trimmed before passed to the function. The function must return `true` or `false`. |
Collaborator
There was a problem hiding this comment.
This is because GitHub lower-case + trims the field names, right? As in the user can't possibly attempt a case-sensitive match
Owner
Author
There was a problem hiding this comment.
Oh which made me think to check if option values are trimmed by GitHub, and indeed they are, I'll adjust the code and then merge it
gr2m
deleted the
25-add-matchfieldname-and-matchfieldoptionvalue-options-for-custom-matching-of-field-names-and-field-option-values
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview of documentation. closes #25