Conversation
… value coming from BUILT_IN_FIELDS type
gr2m
approved these changes
Mar 16, 2022
Comment on lines
+1
to
+5
| { | ||
| "compilerOptions": { | ||
| "strictNullChecks": true | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Does that mean that the projects importing github-project will need the setting as well?
Collaborator
Author
There was a problem hiding this comment.
"Need" only in the sense that if they want to see null types they either need strict mode or strictNullChecks enabled. It works as expected without that setting enabled at the TS level, so string | null just looks like string
|
🎉 This PR is included in version 1.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33
Makes the type of the field value of a project item
string | nulland fixes the string literal value that was coming fromBUILT_IN_FIELDStype.Previously:
item.fields.status: ("Status")After this change:
item.fields.status: (string | null)This more accurately represents the possible (and accepted) values.
Some of the changes may appear duplicative, but this was in the interest of being able to use the
GitHubProjectItemoutside of the context of a project (for example, if the type were imported in directly).The addition of the
jsconfig.jsonwas necessary for me to see the changes since it appearsstrictNullChecksis not enabled by default. https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html#unsupported-patterns