Skip to content

[GR-70208] JVMCI: Make ResolvedJavaType return a List<? extends JavaType> #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

[GR-70208] JVMCI: Make ResolvedJavaType return a List<? extends JavaType> #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/ResolvedJavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,12 +258,13 @@ default ResolvedJavaType getElementalType() {
* whether a type is a direct or indirect permitted subtype. The order of the results matches
* that of {@link Class#getPermittedSubclasses()}.
* <p>
* If the type is not sealed, returns {@code null}.
* If this type is not sealed, returns {@code null}. Returning a list with length 0 means
* this type is sealed and has no permitted subclasses. That is, it is effectively final.
*
* @return unmodifiable list of permitted subtypes, or {@code null} if this type is not sealed
* @see Class#getPermittedSubclasses()
*/
List<JavaType> getPermittedSubclasses();
List<? extends JavaType> getPermittedSubclasses();

/**
* Returns {@code true} if and only if this type represents a sealed class or
Expand Down
4 changes: 2 additions & 2 deletions ...ompiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,7 +740,7 @@ public void getPermittedSubclassesTest() {
private void assertGetPermittedSubclasses(Class<?> clazz) {
ResolvedJavaType type = metaAccess.lookupJavaType(clazz);
assertEquals("Sealed status mismatch for class '" + clazz.getName(), clazz.isSealed(), type.isSealed());
List<JavaType> actual = type.getPermittedSubclasses();
List<? extends JavaType> actual = type.getPermittedSubclasses();
Class<?>[] expected = clazz.getPermittedSubclasses();
if (expected == null) {
assertNull(actual);
Expand Down Expand Up @@ -1356,7 +1356,7 @@ public void getAnnotationDataTest() throws Exception {
"getElementalType",
"getEnclosingType",
"lookupType",
"isSealed", // tested with getPermittedSubsclasses
"isSealed", // tested with getPermittedSubclasses
"resolveField",
"$jacocoInit"
};
Expand Down
Loading