Skip to content

[CI] Ensure artifacts suffix is less than 200 characters #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

[CI] Ensure artifacts suffix is less than 200 characters #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/base-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,20 @@ jobs:
steps:
- id: suffix
run: |
export SUFFIX=$(echo '${{ toJson(inputs) }}' | jq -j 'del(."build-stats-tag", ."mandrel-it-issue-number", ."issue-repo", ."issue-number") | to_entries[] | "-\(.value)"' | tr '":<>|*?\\r\n\/' '-')
echo $SUFFIX
# Build a suffix from inputs but ensure it's safe and has an upper bound on its length (200 characters).
SUFFIX_RAW=$(echo '${{ toJson(inputs) }}' | jq -j 'del(."build-stats-tag", ."mandrel-it-issue-number", ."issue-repo", ."issue-number") | to_entries[] | "-\(.value)"')
# Replace characters that are unsafe for artifact names with '-'
SUFFIX_CLEAN=$(echo "$SUFFIX_RAW" | tr '\":<>|*?\\r\\n\\/' '-' | tr -s '-')
# If the cleaned suffix is reasonably short, use it. Otherwise, create a short stable suffix
# using the run id and a short hash to guarantee length < 256.
MAX_LEN=200
if [ $(echo -n "$SUFFIX_CLEAN" | wc -c) -le $MAX_LEN ]; then
SUFFIX="$SUFFIX_CLEAN"
else
HASH=$(echo -n "$SUFFIX_CLEAN" | sha1sum | cut -c1-40)
SUFFIX="-run${GITHUB_RUN_ID}-${HASH}"
fi
echo "$SUFFIX"
echo "suffix=$SUFFIX" >> $GITHUB_OUTPUT
- name: Get Quarkus version and test matrix
id: version
Expand Down
16 changes: 14 additions & 2 deletions .github/workflows/base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,20 @@ jobs:
steps:
- id: suffix
run: |
export SUFFIX=$(echo '${{ toJson(inputs) }}' | jq -j 'del(."build-stats-tag", ."mandrel-it-issue-number", ."issue-repo", ."issue-number") | to_entries[] | "-\(.value)"' | tr '":<>|*?\r\n\/' '-')
echo $SUFFIX
# Build a suffix from inputs but ensure it's safe and has an upper bound on its length (200 characters).
SUFFIX_RAW=$(echo '${{ toJson(inputs) }}' | jq -j 'del(."build-stats-tag", ."mandrel-it-issue-number", ."issue-repo", ."issue-number") | to_entries[] | "-\(.value)"')
# Replace characters that are unsafe for artifact names with '-'
SUFFIX_CLEAN=$(echo "$SUFFIX_RAW" | tr '":<>|*?\r\n\/' '-' | tr -s '-')
# If the cleaned suffix is reasonably short, use it. Otherwise, create a short stable suffix
# using the run id and a short hash to guarantee length < 256.
MAX_LEN=200
if [ $(echo -n "$SUFFIX_CLEAN" | wc -c) -le $MAX_LEN ]; then
SUFFIX="$SUFFIX_CLEAN"
else
HASH=$(echo -n "$SUFFIX_CLEAN" | sha1sum | cut -c1-40)
SUFFIX="-run${GITHUB_RUN_ID}-${HASH}"
fi
echo "$SUFFIX"
echo "suffix=$SUFFIX" >> $GITHUB_OUTPUT
echo "**artifacts-suffix:** ${SUFFIX}" >> $GITHUB_STEP_SUMMARY
- name: Get Quarkus version and test matrix
Expand Down
Loading