Skip to content

Write out argsFile #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 18, 2025
Merged

Write out argsFile #85

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
305dae4
Write out argsFile
koppor Nov 17, 2025
396213b
Use older Java
koppor Nov 17, 2025
250d022
Add forgotten @
koppor Nov 17, 2025
bcf4c60
Fix typo
koppor Nov 18, 2025
1f8f8fb
Update src/main/java/org/gradlex/javamodule/packaging/tasks/Jpackage.…
koppor Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/main/java/org/gradlex/javamodule/packaging/tasks/Jpackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@
import java.io.File;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.stream.Collectors;
Expand Down Expand Up @@ -112,7 +114,7 @@ public abstract class Jpackage extends DefaultTask {
public abstract DirectoryProperty getDestination();

/**
* To copy resources before adding them. This allows ressource filtering via Gradle
* To copy resources before adding them. This allows resource filtering via Gradle
* FileCollection and FileTree APIs.
*/
@Internal
Expand Down Expand Up @@ -235,15 +237,15 @@ private void performAppImageStep(String jpackage, Directory resourcesDir) {
}

private void configureJPackageArguments(ExecSpec e, Directory resourcesDir) {
String argsFile = createArgsFile(getModulePath().getAsPath());
e.args(
"--module",
getMainModule().get(),
"--resource-dir",
resourcesDir.getAsFile().getPath(),
"--app-version",
getVersion().get(),
"--module-path",
getModulePath().getAsPath(),
argsFile,
"--name",
getApplicationName().get());
if (getApplicationDescription().isPresent()) {
Expand All @@ -269,6 +271,18 @@ private void configureJPackageArguments(ExecSpec e, Directory resourcesDir) {
}
}

private String createArgsFile(String modulePathAsPath) {
Path argsFile = getTemporaryDir().toPath().resolve("args.txt");
List<String> lines = new ArrayList<>(1);
lines.add("--module-path " + modulePathAsPath);
try {
Files.write(argsFile, lines);
} catch (IOException e) {
throw new RuntimeException(e);
}
return "@" + argsFile.toString();
}

private void generateChecksums() throws NoSuchAlgorithmException, IOException {
File destination = getDestination().get().getAsFile();
List<File> allFiles = Arrays.stream(requireNonNull(destination.listFiles()))
Expand Down