Skip to content

Conversation

@mckn
Copy link
Contributor

@mckn mckn commented Oct 22, 2025

Description:
This PR addresses compatibility issues with Grafana 12's panel with immutable targets by adding proper mutability checks before attempting to modify panel properties during migration.

Fixes #408

Question:
The clean up work that mutated the panel. If that can not be applied in G12. Will that create any issues for the function of the panel?

@mckn mckn moved this from 📬 Triage to 🧑‍💻 In development in Plugins Platform / Grafana Community Oct 22, 2025
@mckn mckn moved this from 🧑‍💻 In development to 🔬 In review in Plugins Platform / Grafana Community Oct 22, 2025
@mckn mckn self-assigned this Oct 22, 2025
@mckn mckn changed the title Bug: Migrations will fail in G12 Bugfix: Prevent migration handler from migrating immutable objects Oct 22, 2025
@mckn mckn changed the title Bugfix: Prevent migration handler from migrating immutable objects Bugfix: Prevent migration handler from changing immutable objects Oct 22, 2025
@mckn mckn changed the title Bugfix: Prevent migration handler from changing immutable objects Bugfix: Prevent migration handler from trying to change immutable objects Oct 22, 2025
@mckn mckn requested a review from hugohaggmark October 22, 2025 07:33
Copy link
Contributor

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, it's unlikely g12 instances will still have any of these old properties

@mckn mckn requested a review from briangann October 23, 2025 06:58
@mckn mckn changed the title Bugfix: Prevent migration handler from trying to change immutable objects Bugfix: Prevent migration handler from trying to change targets Oct 28, 2025
@mckn mckn merged commit 5741781 into main Oct 28, 2025
21 checks passed
@mckn mckn deleted the mckn/fixed-migration-issues-in-G12 branch October 28, 2025 10:28
@github-project-automation github-project-automation bot moved this from 🔬 In review to 🚀 Shipped in Plugins Platform / Grafana Community Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🚀 Shipped

Development

Successfully merging this pull request may close these issues.

[BUG] Error in Library Panel, after version update

3 participants