This repository was archived by the owner on Jan 15, 2024. It is now read-only.
client.go: support NumRetries #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If set to nonzero, this will attempt to retry requests if they have something recoverable (such as an error >= 500, or error == 423). This should probably use some more advanced libraries already providing all sorts of backoff strategies as https://github.com/sethgrid/pester/, but considering passing in a cleanhttp struct is somewhat part of its external API, and "this repository being no longer being maintained", as you're "in the process of creating your next generation API clients", simply adding a bit of (dumb) retry logic is probably better than nothing. That way, NumRetries can be set in clients, such as the terraform-provider-grafana, which should workaround terraform issues when trying to describe resources in a (suspended/booting up) Grafana instance (grafana/terraform-provider-grafana#250)
flokli
force-pushed
the
support-num-retries
branch
from
f241273 to
d119eb3
Compare
julienduchesne
approved these changes
Nov 9, 2021
Contributor
julienduchesne
left a comment
julienduchesne
left a comment
There was a problem hiding this comment.
This LGTM. I tested it on the grafana TF provider test suites and it worked. So I'm going to go ahead and merge this
Contributor
Author
|
Thanks! Now we should be able to set |
flokli
added a commit
to flokli/terraform-provider-grafana
that referenced
this pull request
Nov 9, 2021
This includes grafana/grafana-api-golang-client#32
julienduchesne
pushed a commit
to flokli/terraform-provider-grafana
that referenced
this pull request
Nov 12, 2021
This includes grafana/grafana-api-golang-client#32
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If set to nonzero, this will attempt to retry requests if they have something recoverable (such as an error >= 500, or
error == 423).
This should probably use some more advanced libraries already providing all sorts of backoff strategies as
https://github.com/sethgrid/pester/, but considering passing in a cleanhttp struct is somewhat part of its external API,
and "this repository being no longer being maintained", as you're "in the process of creating your next generation API
clients", it probably shouldn't be changed.