-
Notifications
You must be signed in to change notification settings - Fork 97
Chore: Enable style check linter #8
Conversation
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
papagian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Had a quick look. Quite a lot of breaking changes 😊 looking at pkg.go.dev seems like a raintank repo is the only one using go modules and importing it. Seems like most of the imports is of the old https://pkg.go.dev/github.com/nytm/go-grafana-api?tab=importedby so think we can do whatever we want. But probably a good idea to sync with Chris/Malcolm (or others? Not sure who have been involved in this repo earlier) in case my assumptions are wrong? @trotttrotttrott @malcolmholmes do you have any objections on breaking changes in regards to usage of this lib? If not, the idea would be to try and stabilize this library with changes and then push a version tag to start versioning to make it easier to track changes using tags instead of commit hashes |
Thanks @marefr. @trotttrotttrott approved already at least. |
|
@marefr @aknuds1 I'm fully in support of breaking changes. There's a lot that needs updating. I honestly thought this client was on its way to retirement in favor of something like OpenAPI code generation. Which is still a conversation to have. But for now, I'm really happy to see this repo get any attention at all. |
|
@trotttrotttrott Thanks! Yeah, we should look into generating from the API instead. |
marefr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Enable style check linter and fix up code to use the standard casing for initialisms.
It looks as if the old code wasn't following the standard style, but we should be consistent, and might as well follow the standard style, which is what the linter enforces.