Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

@aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Oct 12, 2020

Enable style check linter and fix up code to use the standard casing for initialisms.

It looks as if the old code wasn't following the standard style, but we should be consistent, and might as well follow the standard style, which is what the linter enforces.

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Copy link

@papagian papagian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marefr
Copy link

marefr commented Oct 13, 2020

Had a quick look. Quite a lot of breaking changes 😊 looking at pkg.go.dev seems like a raintank repo is the only one using go modules and importing it. Seems like most of the imports is of the old https://pkg.go.dev/github.com/nytm/go-grafana-api?tab=importedby so think we can do whatever we want. But probably a good idea to sync with Chris/Malcolm (or others? Not sure who have been involved in this repo earlier) in case my assumptions are wrong?

@trotttrotttrott @malcolmholmes do you have any objections on breaking changes in regards to usage of this lib? If not, the idea would be to try and stabilize this library with changes and then push a version tag to start versioning to make it easier to track changes using tags instead of commit hashes

@aknuds1
Copy link
Contributor Author

aknuds1 commented Oct 13, 2020

Had a quick look. Quite a lot of breaking changes 😊 looking at pkg.go.dev seems like a raintank repo is the only one using go modules and importing it. Seems like most of the imports is of the old https://pkg.go.dev/github.com/nytm/go-grafana-api?tab=importedby so think we can do whatever we want. But probably a good idea to sync with Chris/Malcolm (or others? Not sure who have been involved in this repo earlier) in case my assumptions are wrong?

@trotttrotttrott @malcolmholmes do you have any objections on breaking changes in regards to usage of this lib? If not, the idea would be to try and stabilize this library with changes and then push a version tag to start versioning to make it easier to track changes using tags instead of commit hashes

Thanks @marefr. @trotttrotttrott approved already at least.

@trotttrotttrott
Copy link
Contributor

@marefr @aknuds1 I'm fully in support of breaking changes. There's a lot that needs updating. I honestly thought this client was on its way to retirement in favor of something like OpenAPI code generation. Which is still a conversation to have. But for now, I'm really happy to see this repo get any attention at all.

@aknuds1
Copy link
Contributor Author

aknuds1 commented Oct 13, 2020

@trotttrotttrott Thanks! Yeah, we should look into generating from the API instead.

Copy link

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aknuds1 aknuds1 merged commit a805c61 into master Oct 14, 2020
@aknuds1 aknuds1 deleted the chore/linting branch October 14, 2020 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants