fix(go): all actions should be observed #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently do not use a wrapper for _all_ actions because we spawn our own trace spans in our own code. However, this isn't all it does: it also marks a metric, which we currently are missing on the most important pieces. As such, this renames the function so we don't misconstrue what it does, and use it for _all_ actions (even our own!). This will improve our metric outputs.
|
🐳 Docker image built and pushed to GitHub Container Registry. You can pull it using: # For the Node.js server:
docker pull ghcr.io/grafana/grafana-image-renderer:dev-pull-814-99748c64d6340271580ad89719311266604f5ecf
# For the Go server:
docker pull ghcr.io/grafana/grafana-image-renderer:dev-pull-814-99748c64d6340271580ad89719311266604f5ecf-golangWarning This is a development image and should not be used in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently do not use a wrapper for all actions because we spawn our own trace spans in our own code. However, this isn't all it does: it also marks a metric, which we currently are missing on the most important pieces.
As such, this renames the function so we don't misconstrue what it does, and use it for all actions (even our own!). This will improve our metric outputs.