fix(go): return correct CSV file names #828
Merged
+31
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macabu
approved these changes
Oct 24, 2025
|
🐳 Docker image built and pushed to GitHub Container Registry. You can pull it using: # For the Node.js server:
docker pull ghcr.io/grafana/grafana-image-renderer:dev-pull-828-a0a7d92135580a11bd6ac19c786bf1f9de6250fb
# For the Go server:
docker pull ghcr.io/grafana/grafana-image-renderer:dev-pull-828-a0a7d92135580a11bd6ac19c786bf1f9de6250fb-golangWarning This is a development image and should not be used in production. |
dana-axinte
approved these changes
Oct 24, 2025
tskarhed
reviewed
Oct 24, 2025
| MetricRenderCSVDuration.WithLabelValues("success").Observe(time.Since(start).Seconds()) | ||
| span.SetStatus(codes.Ok, "csv rendered successfully") | ||
|
|
||
| requestedFilePath := r.URL.Query().Get("filePath") |
There was a problem hiding this comment.
How is this different to the fileName? Do we ignore cases where this is a path rather than just the filename?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @liamoddell for finding & reporting this ❤️
Test example:
